[SYCL] Remove std::runtime_error that dimensionality of cluster, global and local ranges must be same for sycl_ext_codeplay_cuda_cluster_group extension
#20716
+0
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyniols
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Contributor
Author
|
It's idea and I would like to hear your opinions if we can remove that |
dyniols
changed the title
std::runtime_error that dimensionality of cluster, global and local ranges must be samestd::runtime_error that dimensionality of cluster, global and local ranges must be same for sycl_ext_codeplay_cuda_cluster_group extension
dyniols
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dyniols
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dyniols
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
approved these changes
Nov 21, 2025
Contributor
steffenlarsen
left a comment
steffenlarsen
left a comment
There was a problem hiding this comment.
It doesn't seem like the extension mandated this exception and even if it did it shouldn't be an std::runtime_error but some sycl::exception.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
std::runtime_errorthat dimensionality of cluster, global and local ranges must be same.I don't think that this should be restriction. I can't find anything in https://docs.nvidia.com/cuda/cuda-c-programming-guide/#thread-block-clusters
Here is spec for extension: https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/proposed/sycl_ext_codeplay_cuda_cluster_group.asciidoc